Skip to content

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented Oct 7, 2022

Related: wintercms/storm#46 (specifically: wintercms/storm@b977610)
Mention the new addRelation() methods in the model extension docs.

@mjauvin mjauvin requested a review from bennothommo October 7, 2022 13:03
@mjauvin mjauvin self-assigned this Oct 7, 2022
@LukeTowers
Copy link
Member

@mjauvin could you add some more headings and links to the ToC to more easily find these sections on the page?

@mjauvin
Copy link
Member Author

mjauvin commented Oct 8, 2022

Done @LukeTowers

@LukeTowers
Copy link
Member

@mjauvin I meant also add the anchor tags and the headings to the page's ToC at the top

@mjauvin
Copy link
Member Author

mjauvin commented Oct 12, 2022

@LukeTowers from what I can tell, the new format adds this automatically, unless I am mistaken @bennothommo ?

@mjauvin
Copy link
Member Author

mjauvin commented Feb 19, 2023

Guys, anything preventing this to be merged?

@bennothommo
Copy link
Member

@mjauvin if you could add type hints to those methods - ie. (string $name, array $config) - I'm happy for you to merge.

@mjauvin mjauvin merged commit 77d5763 into wip/1.2-new-format Feb 20, 2023
@mjauvin mjauvin deleted the document-add-relation-methods branch February 20, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants